-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add updates.jenkins.io
storage account, redis database and CNAME record
#445
feat: add updates.jenkins.io
storage account, redis database and CNAME record
#445
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass of review.
- Naming is not blocking
- Using
GRS
sounds like a problem at first sight though
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the plan looks good!
Let's 🤞 that names are ok with the Azure naming constraints (I guess yes)
Follow-up of #445 Ref: jenkins-infra/helpdesk#2649 (comment) --------- Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
* feat: experimental `uc-r2` service * update PV name * reduce PV size from 1000Gi to 1Gi * comment out mirrorbits ingress path * apply review suggestions * remove specific release parameters from mirrorbits, will re-add them only if needed * set PV name so we can reattach to an existing PV without redefining it here * update values (follow up of jenkins-infra/azure#445) and use an azure disk SC * bump mirrorbits chart version * fix secret name ref * full name override to get rid of 'mirrorbits' in objet names * don't override image chart values * adapt file share size to the one declared in jenkins-infra/azure * mount PV as readonly * nameOverride instead of fullnameOverride * use last mirrorbits chart version with service & ingress fixes * changes from last versions of mirrorbits chart * bump the actual chart 🤦
Ref: jenkins-infra/helpdesk#2649