Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updates.jenkins.io storage account, redis database and CNAME record #445

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve marked this pull request as ready for review August 7, 2023 13:57
@lemeurherve lemeurherve requested a review from a team August 7, 2023 13:57
@lemeurherve
Copy link
Member Author

Plan: 4 to add, 0 to change, 0 to destroy.

@dduportal dduportal self-assigned this Aug 7, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review.

  • Naming is not blocking
  • Using GRS sounds like a problem at first sight though

updates.jenkins.io.tf Outdated Show resolved Hide resolved
updates.jenkins.io.tf Outdated Show resolved Hide resolved
updates.jenkins.io.tf Outdated Show resolved Hide resolved
updates.jenkins.io.tf Outdated Show resolved Hide resolved
lemeurherve and others added 3 commits August 7, 2023 16:23
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve requested a review from dduportal August 7, 2023 14:25
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the plan looks good!

Let's 🤞 that names are ok with the Azure naming constraints (I guess yes)

@lemeurherve lemeurherve merged commit 8a6f3e7 into jenkins-infra:main Aug 7, 2023
@lemeurherve lemeurherve deleted the helpdesk2649-storage-account-for-updates-jenkins-io branch August 7, 2023 15:21
lemeurherve added a commit to lemeurherve/kubernetes-management that referenced this pull request Aug 7, 2023
lemeurherve added a commit that referenced this pull request Aug 8, 2023
Follow-up of #445 

Ref:
jenkins-infra/helpdesk#2649 (comment)

---------

Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve added a commit to jenkins-infra/kubernetes-management that referenced this pull request Aug 11, 2023
* feat: experimental `uc-r2` service

* update PV name

* reduce PV size from 1000Gi to 1Gi

* comment out mirrorbits ingress path

* apply review suggestions

* remove specific release parameters from mirrorbits, will re-add them only if needed

* set PV name so we can reattach to an existing PV without redefining it here

* update values (follow up of jenkins-infra/azure#445) and use an azure disk SC

* bump mirrorbits chart version

* fix secret name ref

* full name override to get rid of 'mirrorbits' in objet names

* don't override image chart values

* adapt file share size to the one declared in jenkins-infra/azure

* mount PV as readonly

* nameOverride instead of fullnameOverride

* use last mirrorbits chart version with service & ingress fixes

* changes from last versions of mirrorbits chart

* bump the actual chart 🤦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants