Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't delete existing content on the File Share and fix the destination folder #130

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Nov 15, 2023

This PR:

  • fixes the File Share synchronization as currently this job is erasing the content uploaded to our update center prototype by our update-center2 test job.
  • fixes the folder sync to ensure the content is in the correct destination folder, extracting the SAS token query string from the existing credentials to its own credentials so we can set the destination folder.
  • logs each crawler name before executing them.

Note: while aws-cli creates the folder if needed, azcopy fails with a 404 error: I had to manually create the updates folder in the File Share.

Ref:

@daniel-beck
Copy link
Contributor

Note that this should not delete existing output from the target directory even. https://updates.jenkins.io/updates/ notice anything about the file modification times? Some crawlers don't work, but the existing files will ensure continued operation of the plugins relying of them. They'll just slowly become outdated.

@dduportal
Copy link
Contributor

Note that this should not delete existing output from the target directory even. https://updates.jenkins.io/updates/ notice anything about the file modification times? Some crawlers don't work, but the existing files will ensure continued operation of the plugins relying of them. They'll just slowly become outdated.

absolutely! the deletion only happened in the "new and not used" targets added in #128. The rule of thumb we have is "DO NOT CHANGE THE CURRENT updates.jenkins.io SYSTEM AND PROCESS" => so we don't plan to ever touch the rsync deployment step at all.

@dduportal dduportal marked this pull request as draft November 15, 2023 11:43
@dduportal
Copy link
Contributor

Moving back to draft until @lemeurherve finished his tests

@lemeurherve
Copy link
Member Author

lemeurherve commented Nov 15, 2023

Some crawlers don't work, but the existing files will ensure continued operation of the plugins relying of them. They'll just slowly become outdated.

Thanks for the info!

I imagine we'll have to ensure we copy them over the File Share and the R2 buckets too.

Should we open issues for each of them? (FlywayInstaller & PerlInstaller)

@lemeurherve lemeurherve marked this pull request as ready for review November 15, 2023 12:27
@lemeurherve
Copy link
Member Author

Moving back to draft until @lemeurherve finished his tests

Test successful, ready for review.

@lemeurherve lemeurherve changed the title fix: don't delete other existing content on the File Share fix: don't delete other existing content on the File Share and fix the destination folder Nov 15, 2023
@lemeurherve lemeurherve changed the title fix: don't delete other existing content on the File Share and fix the destination folder fix: don't delete existing content on the File Share and fix the destination folder Nov 15, 2023
@dduportal dduportal merged commit b4de649 into master Nov 15, 2023
1 check passed
@dduportal dduportal deleted the lemeurherve-patch-1 branch November 15, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants