-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't delete existing content on the File Share and fix the destination folder #130
Conversation
Note that this should not delete existing output from the target directory even. https://updates.jenkins.io/updates/ notice anything about the file modification times? Some crawlers don't work, but the existing files will ensure continued operation of the plugins relying of them. They'll just slowly become outdated. |
absolutely! the deletion only happened in the "new and not used" targets added in #128. The rule of thumb we have is "DO NOT CHANGE THE CURRENT updates.jenkins.io SYSTEM AND PROCESS" => so we don't plan to ever touch the |
Moving back to draft until @lemeurherve finished his tests |
Thanks for the info! I imagine we'll have to ensure we copy them over the File Share and the R2 buckets too. Should we open issues for each of them? (FlywayInstaller & PerlInstaller) |
Test successful, ready for review. |
This PR:
Note: while aws-cli creates the folder if needed, azcopy fails with a 404 error: I had to manually create the
updates
folder in the File Share.Ref: