-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mirrorbits): transplant rsyncd
service from rsyncd-mirror
chart
#609
Merged
lemeurherve
merged 9 commits into
jenkins-infra:main
from
lemeurherve:helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits
Aug 22, 2023
Merged
feat(mirrorbits): transplant rsyncd
service from rsyncd-mirror
chart
#609
lemeurherve
merged 9 commits into
jenkins-infra:main
from
lemeurherve:helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
force-pushed
the
helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits
branch
3 times, most recently
from
August 22, 2023 13:57
b5c5aa9
to
3ef34b4
Compare
lemeurherve
added a commit
that referenced
this pull request
Aug 22, 2023
lemeurherve
added a commit
that referenced
this pull request
Aug 22, 2023
…for rsyncd service and ingress
…eplica count independently from mirrorbits deployment
lemeurherve
force-pushed
the
helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits
branch
from
August 22, 2023 17:06
7dea14f
to
b483454
Compare
dduportal
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Diff on get.jenkins looks good, and there are unit tests 👏
lemeurherve
deleted the
helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits
branch
August 22, 2023 17:11
You can proceed to merge: only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the two charts share a lot of templates and values, it makes more sense to extract the
rsyncd
capacity from the old chart to this one instead of updating the old one like this one and keep both maintained.Ref: jenkins-infra/helpdesk#2649