Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mirrorbits): transplant rsyncd service from rsyncd-mirror chart #609

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Aug 22, 2023

As the two charts share a lot of templates and values, it makes more sense to extract the rsyncd capacity from the old chart to this one instead of updating the old one like this one and keep both maintained.

Ref: jenkins-infra/helpdesk#2649

@lemeurherve lemeurherve force-pushed the helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits branch from 7dea14f to b483454 Compare August 22, 2023 17:06
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Diff on get.jenkins looks good, and there are unit tests 👏

@dduportal dduportal added enhancement New feature or request mirrorbits labels Aug 22, 2023
@dduportal dduportal removed their assignment Aug 22, 2023
@lemeurherve lemeurherve merged commit 5ee8235 into jenkins-infra:main Aug 22, 2023
@lemeurherve lemeurherve deleted the helpdesk2649-transplant-rsyncd-service-from-mirror-to-mirrorbits branch August 22, 2023 17:11
@dduportal
Copy link
Contributor

You can proceed to merge: only the updatecli checks fails (as usual)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mirrorbits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants