feat (mirrorbits-parents): add service account #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Oct 27, 2023
dduportal
reviewed
Oct 27, 2023
charts/mirrorbits-parent/tests/custom_values_serviceaccount_test.yaml
Outdated
Show resolved
Hide resolved
dduportal
requested changes
Oct 27, 2023
There was a problem hiding this comment.
2 blockers and 1 non blocker:
- Blockers: The naming convention must not use the
jenkins.prefix for template function names, butmirrorbits-parentinstead. My suggestion are not complete and need a bit more change (it's a starter ;) ) - Non blocker: I don't see the case of the "use existing svc account". See my comment.
dduportal
requested changes
Oct 27, 2023
smerle33
force-pushed
the
mirrorbits/parents/serviceaccount
branch
from
c5f76cc to
3087095
Compare
dduportal
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/update-center2#745 (comment)
and for jenkins-infra/helpdesk#2649
this provide a Service Account for the mirrorbits parents helm chart