fix(publick8s) ensure regexp engine is enabled for updates.jenkins.io ingress paths #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ingress paths Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
approved these changes
Oct 30, 2023
| hosts: | ||
| - host: azure.updates.jenkins.io | ||
| paths: | ||
| - path: / | ||
| backendService: httpd | ||
| - path: /.*[.](deb|hpi|war|rpm|msi|pkg|sha256|md5sum|zip|gz|pdf|json|svg|sh|jpeg|ico|png|html)$ | ||
| - path: /.*[.](deb|hpi|war|rpm|msi|pkg|sha256|md5sum|zip|gz|pdf|json|svg|sh|jpeg|ico|png|html|txt)$ # Requires the regexp engine of Nginx to be enabled |
There was a problem hiding this comment.
txt is added only for our testing isn't it? Should we plan to remove it later?
There was a problem hiding this comment.
Absolutely, this was for tests (and healthchecking mirrors).
Added a new "TODO" in jenkins-infra/helpdesk#2649 (comment) to ensure this pattern list is revised before production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#2649
This PR fixes the failing ingress matching for (azure.)updates.jenkins.io by ensuring the regexp engine is enabled for Nginx (same as get.jenkins.io in fact: annotation was lost when I bootstraped the mirrorbits-parent chart).