Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump up the go version #383

Merged
merged 3 commits into from
Jul 25, 2022
Merged

feat: bump up the go version #383

merged 3 commits into from
Jul 25, 2022

Conversation

Aju100
Copy link

@Aju100 Aju100 commented Jul 24, 2022

No description provided.

@jenkins-x-bot
Copy link
Contributor

Hi @Aju100. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@Aju100
Copy link
Author

Aju100 commented Jul 24, 2022

Fixed the jx-helpers one jenkins-x/jx#8283

Seems like there need to be version upgrade of API and other dependencies too @ankitm123 Correct me if I am wrong here

@Aju100
Copy link
Author

Aju100 commented Jul 24, 2022

/assign @jstrachan @ankitm123

ankitm123
ankitm123 reviewed Jul 24, 2022
View reviewed changes
Copy link
Member

@ankitm123 ankitm123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing

Makefile Outdated Show resolved Hide resolved
@ankitm123
Copy link
Member

ankitm123 commented Jul 24, 2022 •
edited
Loading

@Aju100 now that kube-client has been upgraded to go 1.18.4 (https://github.com/jenkins-x/jx-kube-client/releases/tag/v3.0.4), I think you can also bump the version in go.mod (and run go mod tidy). Saves us one extra PR 😬

@ankitm123
Copy link
Member

Also change commit message to refactor instead of feat - we are not adding any changes to the external facing API.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ankitm123
Copy link
Member

/ok-to-test

@ankitm123
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 3b4e5f3 into jenkins-x:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitm123 ankitm123 ankitm123 left review comments

Assignees

@jstrachan jstrachan

@ankitm123 ankitm123

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aju100 @jenkins-x-bot @ankitm123 @jstrachan