Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jx import should be able to handle repos which the user does not have write access #29

Closed
jstrachan opened this issue Jan 10, 2018 · 6 comments
Labels
area/import kind/enhancement An enhancement of an existing feature lifecycle/rotten

Comments

@jstrachan
Copy link
Member

so rather than doing git commit; git push it generates a new branch (maybe in a fork) and generates a Pull Request with any changes

@i0n
Copy link

i0n commented Jul 6, 2018

We were talking about this today! Perhaps I'll have a look.

@i0n i0n self-assigned this Jul 6, 2018
@jstrachan
Copy link
Member Author

yeah! I wonder if we could query if we had write access; or maybe a CLI argument could decide if import does a PR or a commit/push? I guess the downside of doing a PR to change, say, a Jenkinsfile is if there's an old one in there already its gonna fail. Though I guess a more common use case is there's no Dockerfile/Jenkinsfile so we could still register the project in Jenkins then when the PR is merged, it'd enable the real pipeline?

I guess forking the repo before updating is another option too. Maybe we start with a CLI flag for fork v PR?

@jtnord jtnord added kind/enhancement An enhancement of an existing feature kubecd labels Nov 27, 2018
@rawlingsj
Copy link
Member

/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

@jenkins-x-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

@jenkins-x-bot
Copy link
Contributor

@jenkins-x-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/import kind/enhancement An enhancement of an existing feature lifecycle/rotten
Projects
None yet
Development

No branches or pull requests

7 participants