Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(jenkins api token) fix the api token for new Jenkins version #1555

Merged
merged 5 commits into from Sep 25, 2018
Merged

fix:(jenkins api token) fix the api token for new Jenkins version #1555

merged 5 commits into from Sep 25, 2018

Conversation

ccojocar
Copy link
Contributor

No description provided.

@ccojocar ccojocar requested review from rawlingsj and removed request for i0n and garethjevans August 29, 2018 17:42
@rawlingsj
Copy link
Member

/approve

@ccojocar ccojocar changed the title fix:(jenkins api token) fix the api tokne for new Jenkins version fix:(jenkins api token) fix the api token for new Jenkins version Aug 29, 2018
@ccojocar
Copy link
Contributor Author

/hold

@ccojocar
Copy link
Contributor Author

This works great if already a token exists for an user. In that case, the command jx create jenkins token -p <PASSWORD> --browser <USER> is able to generate successfully another token, and to parse it from the HTML page.

Instead, it does not work if the token table is empty. It seems that the token input form is dynamically inserted into the DOM, and chromedp package is not able to detect this new node into the DOM tree. As a result, the Generate button does not show up into the DOM nodes, therefore the command gets stuck waiting for the button to be visible.

@ccojocar ccojocar force-pushed the fix-jenkins-token-browser branch 2 times, most recently from 83d29de to 848be55 Compare September 24, 2018 15:24
@ccojocar
Copy link
Contributor Author

/hold cancel

@ccojocar
Copy link
Contributor Author

/approve cancel

@ccojocar
Copy link
Contributor Author

/ok-to-test

@ccojocar
Copy link
Contributor Author

@jstrachan @rawlingsj With this refactoring, I think we can upgrade to latest version of jenkins-x-image which contains the latest Jenkins and plugins.

I tested, the installation, create quickstart, create spring and promotion. I haven't found any issue so far.

@jstrachan
Copy link
Member

/approve /lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jstrachan,rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jstrachan,rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit c93c0d9 into jenkins-x:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlingsj rawlingsj Awaiting requested review from rawlingsj

@jstrachan jstrachan Awaiting requested review from jstrachan

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ccojocar @rawlingsj @jstrachan @jenkins-x-bot