-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Simplify merging and fix override of top level env vars #3679
fix: Simplify merging and fix override of top level env vars #3679
Conversation
/hold Working on folding a fix for env vars in pod template containers not being overridden by pipeline/stage env vars here now. |
cbe9705
to
a05367e
Compare
pkg/tekton/syntax/pipeline.go
Outdated
func scopedEnv(newEnv []corev1.EnvVar, parentEnv []corev1.EnvVar, o *RootOptions) []corev1.EnvVar { | ||
// AddContainerEnvVarsToPipeline allows for adding a slice of container environment variables directly to the | ||
// pipeline, if they're not already defined. | ||
func (p *ParsedPipeline) AddContainerEnvVarsToPipeline(origEnv []corev1.EnvVar) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
receiver name p should be consistent with previous receiver name j for ParsedPipeline
Derived from what I've done over at tektoncd/pipeline#767 - this is just cleaner, simpler, better.
a05367e
to
3406b37
Compare
/hold cancel Ok, fix for |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstrachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Submitter checklist
Description
Derived from what I've done over at tektoncd/pipeline#767 - this is just cleaner, simpler, better.
Special notes for the reviewer(s)
/assign @dwnusbaum
Which issue this PR fixes
n/a