Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: mock existing local function. #465

Merged

Conversation

nestoracunablanco
Copy link
Contributor

@nestoracunablanco nestoracunablanco commented Jan 2, 2022

The mock is not applicable in case the function already exists and the specified closure is null.

Link to the issue: #461

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message so that the subject describes the change actually being made. When looking at the commit in git log, it should be clear to the reader what is happening without needing to navigate to GitHub and look up a closed issue.

The commit message body is fine and can be left as-is.

The mock was not applicable in case the function already exists and the specified closure is null.
@nestoracunablanco
Copy link
Contributor Author

@nre-ableton the commit message is changed. Thanks for reviewing!

@nre-ableton nre-ableton changed the title Bugfix: #461 Bugfix: mock existing local function. Jan 7, 2022
@nre-ableton nre-ableton merged commit 8906c47 into jenkinsci:master Jan 7, 2022
@nestoracunablanco nestoracunablanco deleted the bugfix/mockOnDeclarative branch April 1, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants