[JENKINS-31746] Improve the layout

[recena]

JENKINS-31746

• Centered option labels and readability.
• Full-width layout
• Bigger clean up (HTML & CSS)
• Fix tests (it will be moved to a new issue)

Before

After

@reviewbybees & @dalvizu

[amuniz]

🐝

[dalvizu]

Requiring our users to upgrade their Jenkins is something I don't want to do without a very good reason to do so: it puts up a barrier to using our plugin. If there is a reason we can't continue using 1.609.3, please list it

[recena]

Sure. In this issue JENKINS-28550, and its PR. This PR was release in 1.619.

[dalvizu]

+1 but please see comments about requiring core upgrade. If we must, we must, but I'd prefer to avoid requiring our users to upgrade their core version.

[recena]

@dalvizu I agree with you but 1.619 included important changes in Jenkins UI Layout.

[recena]

@dalvizu If you have a chance, could you chech the changes proposed in this PR? It is in WiP but...a screenshot will be great.

[tfennelly]

🐝 insofar as I can see.

[recena]

@tfennelly Thanks for your feedback,

[KostyaSha]

Left menu appeared again? Sounds like somebody changed css in core again.

[recena]

@KostyaSha Jenkins layout was modified in 1.609. Now, is overridden properly.

[recena]

@KostyaSha Sometimes overriding CSS Styles is the only way to do some things, but it is a very bad practice. It would be nice if Jenkins offer a way to use differents layouts (main-content, 2-columns, etc...), working on it.

[KostyaSha]

@recena i had some discussions before (with @tfennelly ?) that view plugin should have ability have full screen place and not right space.

[recena]

@kohsuke I totally agree with you. I have some ideas about how to do this.

[recena]

I meant @KostyaSha ;)

[dalvizu]

As requested @recena, here are my pipelines with the UI changes:

Before:

After:

Before:

After:

[recena]

@dalvizu Thanks. I have to continue working here. The result is not still positive.

[recena]

@dalvizu Please, find a screenshot with the current status:

[recena]

@dalvizu If you agree, I would like to cut a release (alpha) with this PR. What do you think about it?

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[andresrc]

🐝

[cdenneen]

@recena Would it be possible to have this plugin support 2 parent jobs?
We have a workflow that can be triggered on one of 2 jobs... the child job has either listed as parent... and if build of child isn't triggered by the P1 but by P2 it uses the Promoted Build Plugin to find latest successful P1 build and uses that for continuing... so the workflow looks a bit like

P1 - - - \
          D1 - - - D2 
P2 - - - /

[recena]

@cdenneen This is not the right place to discuss about new features. Please, fill a Jira issue.

[giuspen]

• The "Console Output Link Style" set to "Lightbox" doesn't work for me, I'm on firefox 44.0.2, Win7. The overlay window results empty. "New Window" and "This Window" work
• The text that was before bold was more readable for us that have the view on a big monitor. Especially the build number in the first left column, under "Pipeline" that now is also attached to the header, not centered like before (see screenshot)
  

[recena]

@giuspen Thanks for your feedback. Would it be possible a screenshot?

[giuspen]

@recena I edited my feedback adding the screenshot. Thanks for your Work.

[recena]

@giuspen About The text that was before bold was more readable for us that have the view on a big monitor. well, you can resize your fonts, especially if you are using a big screen.

[recena]

@giuspen With new proposal, each execution of your pipeline is a row independent. Anyway, I'll take a quick review before to cut a new release at the end of this week.

[dalvizu]

well, you can resize your fonts, especially if you are using a big screen.

Is this acceptable for you @giuspen?

@recena - perhaps compare the two side by side and get community feedback on what they would like? It sounds like this may increase the width a bit, but it also sounds like that might be an acceptable trade-off, at least worth discussing.

[giuspen]

The best visualisation is for us (font very visible and great graphic) the
one of https://wiki.jenkins-ci.org/display/JENKINS/Build+Monitor+Plugin
This bugfix is very important so we prefer the beta to the old stable;
having said so the bold font and the more rounded squares were more nice to
the eye than the thick font and non smoothed corners. The disabled jobs are
instead better represented in the new beta rather than the old stable.
On 17 Feb 2016 17:59, "Dan Alvizu" notifications@github.com wrote:

well, you can resize your fonts, especially if you are using a big screen.

Is this acceptable for you @giuspen https://github.com/giuspen?

@recena https://github.com/recena - perhaps compare the two side by
side and get community feedback on what they would like? It sounds like
this may increase the width a bit, but it also sounds like that might be an
acceptable trade-off, at least worth discussing.

—
Reply to this email directly or view it on GitHub
#95 (comment)
.

[recena]

@dalvizu I propose to cut a release (1.5.0) and begin to iterate over the details, bugs and tests. In fact, I'd like to move the current functional tests to Jenkins ATH. /cc @giuspen