Skip to content

Conversation

MarkEWaite
Copy link
Contributor

Declare dependencies explicitly

Do not allow additions to the bundled dependencies without a change to the list of bundledArtifacts. Avoid the mistakes when a new transitive dependency might be inadvertently added to the plugin and bundled into the hpi / jpi file.

Thanks to pull request:

Testing done

Confirmed that tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Do not allow additions to the bundled dependencies without a change to
the list of bundledArtifacts.  Avoid the mistakes when a new transitive
dependency might be inadvertently added to the plugin and bundled into
the hpi / jpi file.

Thanks to pull request:

* jenkinsci/maven-hpi-plugin#771
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Aug 16, 2025
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 16, 2025 02:59
@MarkEWaite MarkEWaite merged commit 053404c into jenkinsci:master Aug 16, 2025
17 checks passed
@MarkEWaite MarkEWaite deleted the explicitly-declare-dependencies branch August 16, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Reduces maintenance effort by changes not directly visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant