Use JDK 8u332, not JDK 8u322 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
May 11, 2022
Comment on lines
23
to
+26
| # FIXME(oleg_nenashev): This is not an official AdoptOpenJDK Docker Image. | ||
| # There is no official Alpine images at the moment. | ||
| # Needs upgrade when/if there is an official alpine image. | ||
| FROM adoptopenjdk/openjdk8:x86_64-alpine-jdk8u322-b06 | ||
| FROM adoptopenjdk/openjdk8:x86_64-alpine-jdk8u332-b09 |
There was a problem hiding this comment.
Suggested change
| # FIXME(oleg_nenashev): This is not an official AdoptOpenJDK Docker Image. | |
| # There is no official Alpine images at the moment. | |
| # Needs upgrade when/if there is an official alpine image. | |
| FROM adoptopenjdk/openjdk8:x86_64-alpine-jdk8u322-b06 | |
| FROM adoptopenjdk/openjdk8:x86_64-alpine-jdk8u332-b09 | |
| FROM eclipse-temurin:8u332-b09-jre-alpine |
There is (now) an official temurin alpine distribution (only Intel though, but @gounthar is on the case for ARM support in the future ;) )
There was a problem hiding this comment.
I've not been able to make the tests pass with the change from the adoptopenjdk to the eclipse-temurin image. I had tried it previously without success and decided that it would be better to leave it for another pull request.
There was a problem hiding this comment.
No problem. Then let's proceed to merging this PR: I've opened #119 as a draft for the switch to temurin then
dduportal
reviewed
May 11, 2022
dduportal
approved these changes
May 11, 2022
Merged
6 tasks
dduportal
added a commit
to dduportal/docker-ssh-slave
that referenced
this pull request
May 11, 2022
- Removing leftover comments from jenkinsci#118 - Alpine Linux's `apk update` command is not needed as it's called as part of `apt add` when using `--no-cache` or `--update` flags
timja
pushed a commit
that referenced
this pull request
May 15, 2022
- Removing leftover comments from #118 - Alpine Linux's `apk update` command is not needed as it's called as part of `apt add` when using `--no-cache` or `--update` flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JDK 8u332, not JDK 8u322
Ensure you have provided tests - that demonstrates feature works or fixes the issue