Batch of updates for the image #12
Conversation
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com> Cleaning Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
…lysis of bad keys Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
…nfusion when building from Windows Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Dockerfile
Outdated
| RUN sed -i 's/#PasswordAuthentication yes/PasswordAuthentication no/' /etc/ssh/sshd_config | ||
| RUN apt-get update \ | ||
| && apt-get install --no-install-recommends -y \ | ||
| openssh-server git \ |
There was a problem hiding this comment.
I am not convinced Git is required in the image.
Good for demos, but Jenkins has tool installers which can install a portable Git client
| mkdir -p "${JENKINS_AGENT_HOME}/.ssh" | ||
| echo "$1" > "${JENKINS_AGENT_HOME}/.ssh/authorized_keys" | ||
| chown -Rf jenkins:jenkins "${JENKINS_AGENT_HOME}/.ssh" | ||
| chmod 0700 -R "${JENKINS_AGENT_HOME}/.ssh" |
There was a problem hiding this comment.
I will follow-up in the PM
There was a problem hiding this comment.
Not sure to understand this ?
tests/test_helpers.bash
Outdated
| @@ -1,4 +1,4 @@ | |||
|
|
|||
| #!/bin/bash | |||
There was a problem hiding this comment.
Gotcha, updated :)
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
|
Git removed, and secured the bash helper for tests. Not sure to get WDYM by the PM follow up (what is the PM acronym for ? ) |
Hello there !
Follow up of #11 without alpine.
After some time using my own image which purpose is almost the same as this one, here is an update proposal that cover an upgrade to latest docker practises (1.13.2 at the time starting this PR), Jenkins SSH usages, and also shrinking the image to spend less disk space.
Here are the major changes: