tests(windows) re-enable failing test(s) on AWS #538
Conversation
…infra/helpdesk#4557 infra issue is resolved"""
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
revert-531-revert-496-revert-495-helpesk4557-disable-failing-test-for-now
branch
from
ea1209b to
bbdce5f
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
deleted the
revert-531-revert-496-revert-495-helpesk4557-disable-failing-test-for-now
branch
tests/sshAgent.Tests.ps1
Outdated
| It 'can check running containers' { | ||
| $exitCode, $stdout, $stderr = Run-Program 'docker' "container ls" | ||
| $exitCode | Should -Be 0 | ||
| } | ||
|
|
||
| It 'can get logs of running container' { | ||
| $exitCode, $stdout, $stderr = Run-Program 'docker' "logs `"$global:CONTAINERNAME`"" | ||
| $exitCode | Should -Be 0 |
There was a problem hiding this comment.
@dduportal: Was removing those tests intentional? Looking at the commit message, it doesn't seem so.
There was a problem hiding this comment.
Nevermind, these changes don't appear in https://github.com/jenkinsci/docker-ssh-agent/pull/538/files
There was a problem hiding this comment.
Yes it was intentional as per the PR description:
Removed all the "sub steps" added to debug the problem in march/April 2025 and that we did clean since then (checking list of containers, getting logs of container, etc.)
There was a problem hiding this comment.
(note: these 2 blocks were not test in any way, or you have to explain what were they testing ;) )
There was a problem hiding this comment.
I was a bit confused when reviewing your PR commit per commit without taking too much attention to the PR body. My bad, make perfect sense now, thanks for the explanations!
There was a problem hiding this comment.
Thanks for the careful review! 👍
Ref. jenkins-infra/helpdesk#4557
This PR is focused on the Windows test harnesses and reverts #531 along with a few changes to allow these tests to be run without failures.
The main change is to remove the embedded
ssh.exeand its dll binary file and instead rely on thessh.exein the environment where the tests are running. These binary where introduced 5 years ago in #49:ssh.exeis not really up to date and refuses the ciphers set in the SSH server of the SUT)A few cleanups are also added:
Start-Sleep -Seconds 10instructions: unneeded anymore