fix "Unknown content type null" in logs and since for 1.12.0 api #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lanwen
commented
Jul 29, 2015
lanwen
commented
- some small changes (see commits) to help implementing future prs
added 5 commits
July 29, 2015 16:24
will be useful in repository name
caused by self-test validation for custom hook url
| @@ -118,6 +118,8 @@ protected GHRepository adapt(GitHub item) { | |||
| * | |||
| * This is useful if the caller only relies on the read access to the repository and doesn't need to | |||
| * walk possible candidates. | |||
| * | |||
| * Result can be null | |||
| */ | |||
| public GHRepository resolveOne() { | |||
| @@ -118,7 +119,10 @@ protected GHRepository adapt(GitHub item) { | |||
| * | |||
| * This is useful if the caller only relies on the read access to the repository and doesn't need to | |||
| * walk possible candidates. | |||
| * | |||
| * Result can be null | |||
There was a problem hiding this comment.
remove this line, checkfornull is enough or if you want java doc then change to @return desc
KostyaSha
added a commit
that referenced
this pull request
Jul 29, 2015
fix "Unknown content type null" in logs and since for 1.12.0 api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.