Update gitlab4j to 6.1.0, update Jenkins BOM, require Jenkins 2.479.3 #121
Conversation
|
@basil I think this is now ready, except for the incremental repo (which should be reverted with |
|
@zbynek as the maintainer of GitLab4J I have been asked in issue gitlab4j/gitlab4j-api#1280 to create a From my understanding some installations are broken today (see jenkinsci/gitlab-branch-source-plugin#504) Maybe you can use this |
|
Thanks! Not a maintainer, so not my decision In the meanwhile I've open #122 |
There was a problem hiding this comment.
This still requires a release of jersey3-api plugin and jenkinsci/jackson2-api-plugin#312 to be merged.
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>javax-activation-api</artifactId> |
There was a problem hiding this comment.
This needs to be replaced by jakarta-activation-api
| <artifactId>jakarta-activation-api</artifactId> |
| <artifactId>gitlab4j-api</artifactId> | ||
| <version>${revision}</version> | ||
| <exclusions> | ||
| <!-- Provided by javax-activation-api plugin --> |
There was a problem hiding this comment.
| <!-- Provided by jakarta-activation-api plugin --> |
| <groupId>jakarta.servlet</groupId> | ||
| <artifactId>jakarta.servlet-api</artifactId> | ||
| </exclusion> | ||
| <!-- Provided by jersey2-api plugin --> |
There was a problem hiding this comment.
| <!-- Provided by jersey3-api plugin --> |
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>jersey2-api</artifactId> | ||
| <artifactId>jersey3-api</artifactId> | ||
| <version>3.1.11-2.v4a_b_db_cf4557b_</version> |
There was a problem hiding this comment.
I opened jenkins-infra/repository-permissions-updater#4663 so that I can release jersey3-api and then add it in BOM.
| <version>3.1.11-2.v4a_b_db_cf4557b_</version> | |
| <!-- TODO until jersey3-api is in BOM --> | |
| <version>3.1.11-2.v4a_b_db_cf4557b_</version> |
| <repository> | ||
| <id>incrementals</id> | ||
| <url>https://repo.jenkins-ci.org/incrementals/</url> | ||
| </repository> |
There was a problem hiding this comment.
That shouldn't be required as there is
gitlab-api-plugin/.mvn/maven.config
Line 1 in 322a9d1
|
@zbynek do you think you can revisit this pull request? |
|
@alecharp thanks for your feedback, I'll look into those suggestions once |
Partial fix for https://issues.jenkins.io/browse/JENKINS-76091
Closes #114
Closes #113
Unlike #114 this also updates BOM to latest to resolve some upper bound issues. The latest BOM requires Jenkins 2.479.3 because of
I picked a more conservative baseline increment because the recently relesed Jackson API plugin breaks compatibility with this plugin and it has 2.479.1 baseline.
Testing done
Automated tests passing.
Submitter checklist