Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters to patch AcceptGitLabMergeRequestStep.java #1455

Merged

Conversation

harsh-ps-2003
Copy link
Contributor

@harsh-ps-2003 harsh-ps-2003 commented Apr 18, 2023

When using Snippet Generator of pipeline generator for acceptGitLabMR this error message comes - no public field ‘useMRDescription’ (or getter method) found in class com.dabsquared.gitlabjenkins.workflow.AcceptGitLabMergeRequestStep. Adding required getters to patch this issue.

Closes #692

@harsh-ps-2003 harsh-ps-2003 requested a review from a team as a code owner April 18, 2023 19:49
@harsh-ps-2003 harsh-ps-2003 changed the title Add getters to patch AcceptGitLabMergeRequest.java Add getters to patch AcceptGitLabMergeRequestStep.java Apr 18, 2023
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@krisstern krisstern enabled auto-merge (squash) April 19, 2023 01:24
@krisstern krisstern added the bug For changelog: Minor bug. Will be listed after features label Apr 19, 2023
@krisstern krisstern merged commit 6975e93 into jenkinsci:master Apr 19, 2023
@harsh-ps-2003 harsh-ps-2003 deleted the snippet-generator-mr-getters branch April 19, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippet Generator for pipeline triggers broken
2 participants