Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag ref when setting build status. #944

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

jukov
Copy link
Contributor

@jukov jukov commented Jul 11, 2019

I have same issue described in #677.

After review pull #774 i figured out not only CommitStatusUpdater update build status, and remove branch ref in other places.

@thomas955
Copy link

We had the same issue with Jenkins CI -> and Tag pushing from gitlab.
Like discussed here and in #677 the behaviour is 100% the same.

I compiled the gitlab plugin with the changes from jukov and for me its working so far. it would be nice if this could be merged as soon as possible into the official gitlab-jenkins plugin

Thanks @jukov

p.s. there is a stackoverflow post with the same problem
https://stackoverflow.com/questions/52933087/double-pipelines-on-gitlab-tag-webhook

@rlfnb
Copy link

rlfnb commented Sep 2, 2019

@omehegan Would be great to see it merged, still running into the same problem being described and already fixed in the PR sent by @jukov

@markjacksonfishing
Copy link
Contributor

@jukov Is there an associated Github issue with this PR? What about a Jenkins jira? If so, can you link them? If not, can you open them and note this PR?
Thank you for that.

@thomas955
Copy link

@omehegan Is it possible to merge this into the master soon? Would be nice.
Thank you in advance.

@thomas955
Copy link

Just created a ticket in jira: see https://issues.jenkins-ci.org/browse/JENKINS-60233

@markjacksonfishing markjacksonfishing merged commit 0c3b3ce into jenkinsci:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants