-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger build only when new commits were pushed to MR #998
Trigger build only when new commits were pushed to MR #998
Conversation
# Conflicts: # src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java # src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/merge/MergeRequestHookTriggerHandlerFactory.java # src/main/java/com/dabsquared/gitlabjenkins/trigger/handler/merge/MergeRequestHookTriggerHandlerImpl.java
Hi @anton-johansson! Thank you very much for changes introduced in #903! They were exactly what I needed to finish this PR and I had no idea how to implement them by myself. If you have some spare time I humbly ask you to review this PR because I think it can interfere with your changes (I've tried to resolve conflicts as accurate as possible) |
test compilation was failed because of this
This is to not to interfere with changes introduced by jenkinsci#903
@anton-johansson it did interfere with your changes, so I slightly changed a condition and now MR will be built anyway if force build labels were set |
Can we assign someone to review and merge changes? It is a very desired fix. |
@markyjackson-taulia can you please take a look? |
Thank you @markyjackson-taulia ! |
@ababushk was this issue "However, in current implementation build won't start when work in progress merge request become non-WIP MR." fixed as well? I see that when we move MR from "WIP" to Ready, pipeline does not start |
@sandeepnagori87 It's been a while, so I don't remember details, but according to Line 260 in 76afae8
|
This PR resolves the problem described in #871 and #926
An option in trigger configuration was added - when set build will be started on MR update only if it has new commits pushed to source branch. However, in current implementation build won't start when work in progress merge request become non-WIP MR.
I can use some help to write tests and fix the issue with WIP merge requests.