Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quality check plugins with functions #222

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

alextu
Copy link

@alextu alextu commented Mar 20, 2023

This avoids applying the plugin(s) if not explicitly required by exposing functions instead of boolean flags.
See original discussion #220 (comment)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This avoids applying the plugin(s) if not explicitly required.
@sghill sghill merged commit a5eacd1 into jenkinsci:master Mar 20, 2023
@sghill
Copy link

sghill commented Mar 20, 2023

Thanks @alextu! This was released as 0.48.0-rc.3 if you'd like to test it out. I usually run with the candidate for about a week and promote to release if there are no issues.

@alextu alextu deleted the atual/fix-checks branch March 20, 2023 20:53
@sghill
Copy link

sghill commented Apr 12, 2023

0.48.0 was released today with this change

@alextu alextu mentioned this pull request Apr 17, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants