Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing Guide is created. #111

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Contributing Guide is created. #111

merged 2 commits into from
Sep 28, 2022

Conversation

duemir
Copy link
Member

@duemir duemir commented Sep 28, 2022

Fixes #75.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@duemir duemir added the internal Pull requests that update anything related to building the plugin but not the plugin itself label Sep 28, 2022
@duemir duemir self-assigned this Sep 28, 2022
@duemir duemir added documentation and removed internal Pull requests that update anything related to building the plugin but not the plugin itself labels Sep 28, 2022
timja
timja previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

CONTRIBUTING.md Outdated Show resolved Hide resolved
@duemir @timja
Update CONTRIBUTING.md
4789c7a 
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@duemir duemir merged commit c8e69e5 into jenkinsci:master Sep 28, 2022
@duemir duemir deleted the idea-stapler-plugin-75 branch September 29, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

Assignees

@duemir duemir

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Contributing Guide
2 participants
@duemir @timja