Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hardcoding releases to verify against by using JetBrains Gradle plugin feature that lists the releases #118

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Oct 11, 2022

Fixes #100

Configuration of runPluginVerifier with list generated from listProductsReleases with sinceVersion.

Example of output when running gradle runPluginVerifier -PideaVersion=2022.2.3 :

> Task :listProductsReleases
IC-2022.3
IC-2022.2.3
IC-2022.1.4
IC-2021.3.3
IC-2021.2.4
IC-2021.1.3
IC-2020.3.4
> Task :verifyPlugin
Download https://cache-redirector.jetbrains.com/download.jetbrains.com/idea/ideaIC-2021.3.3.tar.gz (32.73 MB / 802.97 MB)> Task :runPluginVerifier
Download https://cache-redirector.jetbrains.com/download.jetbrains.com/idea/ideaIC-2021.3.3.tar.gz, took 5 m 46 s 838 ms (802.97 MB)
Download https://cache-redirector.jetbrains.com/download.jetbrains.com/idea/ideaIC-2021.2.4.tar.gz, took 4 m 14 s 968 ms (839.65 MB)
Download https://cache-redirector.jetbrains.com/download.jetbrains.com/idea/ideaIC-2021.1.3.tar.gz, took 3 m 58 s 671 ms (817.03 MB)
Download https://cache-redirector.jetbrains.com/download.jetbrains.com/idea/ideaIC-2020.3.4.tar.gz, took 3 m 22 s 420 ms (734.53 MB)
Starting the IntelliJ Plugin Verifier 1.287
...
2022-10-11T00:50:18 [main] INFO  verification - Task check-plugin parameters:
Scheduled verifications (7):
Stapler plugin for IntelliJ IDEA:2.0.8 against IC-223.6160.11, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-222.4345.14, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-221.6008.13, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-213.7172.25, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-212.5712.43, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-211.7628.21, Stapler plugin for IntelliJ IDEA:2.0.8 against IC-203.8084.24

2022-10-11T00:50:19 [main] INFO  verification - Finished 1 of 7 verifications (in 0.6 s): IC-212.5712.43 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:19 [main] INFO  verification - Finished 2 of 7 verifications (in 1.1 s): IC-213.7172.25 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:20 [main] INFO  verification - Finished 3 of 7 verifications (in 1.2 s): IC-221.6008.13 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:20 [main] INFO  verification - Finished 4 of 7 verifications (in 1.2 s): IC-203.8084.24 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:20 [main] INFO  verification - Finished 5 of 7 verifications (in 1.2 s): IC-223.6160.11 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:20 [main] INFO  verification - Finished 6 of 7 verifications (in 1.2 s): IC-222.4345.14 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
2022-10-11T00:50:20 [main] INFO  verification - Finished 7 of 7 verifications (in 1.2 s): IC-211.7628.21 against Stapler plugin for IntelliJ IDEA:2.0.8: Compatible
Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-212.5712.43: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-213.7172.25: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-221.6008.13: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-203.8084.24: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-223.6160.11: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-222.4345.14: Compatible
    Plugin can be loaded/unloaded without IDE restart

Plugin Stapler plugin for IntelliJ IDEA:2.0.8 against IC-211.7628.21: Compatible
    Plugin can be loaded/unloaded without IDE restart

2022-10-11T00:50:20 [main] INFO  verification - Total time spent downloading plugins and their dependencies: 0 ms
2022-10-11T00:50:20 [main] INFO  verification - Total amount of plugins and dependencies downloaded: 0 B
2022-10-11T00:50:20 [main] INFO  verification - Total amount of space used for plugins and dependencies: 0 B
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@duemir duemir self-requested a review October 11, 2022 05:46
@duemir duemir added Hacktoberfest pipeline Build/Release pipeline work labels Oct 11, 2022
@duemir duemir added this to the Hacktoberfest2022 milestone Oct 11, 2022
gradle.properties Outdated Show resolved Hide resolved
Copy link
Member

@duemir duemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let us try the following. The sinceIdeaVersion should default to the value of ideaVersion unless explicitly specified.

gradle.properties Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Denys Digtiar <duemir@gmail.com>
@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 13, 2022

@duemir, cool, thanks for your suggestions!

Works for me:

% gradle listProductsReleases -PideaVersion=2022.2                          

> Task :listProductsReleases
IC-2022.3
IC-2022.2.3
% gradle listProductsReleases -PideaVersion=2022.2 -PsinceIdeaVersion=2020.1

> Task :listProductsReleases
IC-2022.3
IC-2022.2.3
IC-2022.1.4
IC-2021.3.3
IC-2021.2.4
IC-2021.1.3
IC-2020.3.4
IC-2020.2.4
IC-2020.1.4

👍🏼

@duemir duemir changed the title IntelliJ plugin verifier does not seem to required IDE versions anymore Avoid hardcoding releases to verify agains, by using JetBrains Gradle plugin feature that lists the releases Oct 13, 2022
@duemir duemir merged commit 96ab459 into jenkinsci:master Oct 13, 2022
@duemir duemir changed the title Avoid hardcoding releases to verify agains, by using JetBrains Gradle plugin feature that lists the releases Avoid hardcoding releases to verify against by using JetBrains Gradle plugin feature that lists the releases Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline Build/Release pipeline work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntelliJ plugin verifier does not seem to required IDE versions anymore
2 participants