Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage new JellyFile type in more of the codebase #122

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Leverage new JellyFile type in more of the codebase #122

merged 2 commits into from
Nov 3, 2022

Conversation

duemir
Copy link
Member

@duemir duemir commented Nov 3, 2022 •
edited
Loading

As discussed with @jgreffe . After his introduction of Jelly Language and file type, things could be simplified.

  • JellyFileTypeSchema is left but the only public API now are constants that define Jelly extensions
  • Where no longer necessary checks that the current file is Jelly are removed
  • Where still necessary, instead of extension, a type of file object is checked instead.
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

duemir added 2 commits November 3, 2022 13:32
@duemir
Leverage new JellyFile type in more of the codebase
454b013 
Rely on new Jelly language and file type as a condition for contributing features.
@duemir
Leverage new JellyFile type in more of the codebase
3f338a3 
Tidy up a few more places.
@duemir duemir added the internal Pull requests that update anything related to building the plugin but not the plugin itself label Nov 3, 2022
@duemir duemir requested a review from timja November 3, 2022 07:39
@duemir duemir self-assigned this Nov 3, 2022
@duemir duemir merged commit c659066 into jenkinsci:master Nov 3, 2022
@duemir duemir deleted the jelly-file-instead-of-ext branch November 17, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgreffe jgreffe jgreffe approved these changes

@timja timja timja approved these changes

Assignees

@duemir duemir

Labels
internal Pull requests that update anything related to building the plugin but not the plugin itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duemir @timja @jgreffe