Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n with single-quote exception Argument rangeInElement (9,25) endOffset must not exceed descriptor text range (38, 62) length (24) #127

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Nov 25, 2022

Fixes #126

  • handle case of non-closed quotes
  • unescape content before parsing
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…25) endOffset must not exceed descriptor text range (38, 62) length (24)
Copy link
Member

@duemir duemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance:

  • It looks like there are unused imports:
  • The logging should be done at debug level, not warning IMO (There is Logger#debugValues(String, Collection) which looks similar to what you are doing)

@jgreffe
Copy link
Contributor Author

jgreffe commented Nov 28, 2022

At first glance:

  • It looks like there are unused imports:

Yes, I'll fix it.

  • The logging should be done at debug level, not warning IMO (There is Logger#debugValues(String, Collection) which looks similar to what you are doing)

Not sure here, this means when a user reports an issue, he has to change log level before sharing?

@jgreffe jgreffe requested a review from duemir November 30, 2022 07:26
@duemir
Copy link
Member

duemir commented Dec 13, 2022

Not sure here, this means when a user reports an issue, he has to change log level before sharing?

And that is fine. Users are highly technical.
The nature of logs is tracing method calls, not reporting a recoverable issue.
Hence, debug level is more appropriate, in my opinion.

@duemir duemir added the bug label Jan 30, 2023
@duemir duemir merged commit 4e603d0 into jenkinsci:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants