-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jelly Tag Library XSDs #149
Conversation
Curiously I don't see |
A couple of classes register the ExprTag: The "expr" takes precedence, first come first served rules, I assume. The javadoc comments are registered under this tag name. That's the only tag that's registered twice, no idea why it's been done like that. I see we use |
Ideally, the IntelliJ plugin reads the schema directly from the Java files that implement the tags, but it is a sizable chunk of work. XSDs are an expedient way of adding support. I can merge this, duplicate the Regarding removing |
Sounds good! |
And remove the empty element tag
These are Tag classes that are registered multiple times.
It was missing because it is implemented as a TagScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of XSDs had an invalid, empty element definition <xsd:element name="">
A surprising number of Stapler tags were not previously in the schema.
Two that are still there were removed (st:documentation
, st:once
). I am guessing they were added by hand. There was a third TagScript tag that is not handled by a generator that was missing st:getOutput
. I added them all back.
I think XSDs look decent now.
These updates have been generated by running
mvn clean org.jvnet.maven-jellydoc-plugin:maven-jellydoc-plugin:1.11:jellydoc
in the jelly and stapler repository. The output aligns with the format we're using there and the binaries produced.To note, there are more XSDs available in the https://github.com/jenkinsci/jelly/tree/master/jelly-tags folder, but we don't build or distribute these, and they are not maven-ized. Therefore, I didn't include XSD updates for them.
Closes #145
Fixes #92