Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usages of Apache commons-lang2 are removed for IntelliJ compatibility reasons #168

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

duemir
Copy link
Member

@duemir duemir commented Oct 17, 2023

According to https://plugins.jetbrains.com/docs/intellij/api-changes-list-2023.html#8c50ccb_40 commons-lang2 and commons-collections libraries are being removed. Usages are replaced with IntelliJ and commons-text alternatives.

Fixes #167

Testing done

Submitter checklist

Preview Give feedback

According to https://plugins.jetbrains.com/docs/intellij/api-changes-list-2023.html#8c50ccb_40 commons-lang2 and commons-collections libraries are being removed. Usages are replaced with IntelliJ and commons-text alternatives.
@duemir duemir added the internal Pull requests that update anything related to building the plugin but not the plugin itself label Oct 17, 2023
@duemir duemir changed the title Usages of Apache commons-lang2 are removed Usages of Apache commons-lang2 are removed for IntelliJ compatibility reasons Oct 17, 2023
@duemir
Copy link
Member Author

duemir commented Oct 17, 2023

https://ci.jenkins.io/job/Plugins/job/idea-stapler-plugin/job/master/79/ and check artifacts for report.html of the IC-233.9802.14. It is compatible but shows deprecation warnings.
Same report in https://ci.jenkins.io/job/Plugins/job/idea-stapler-plugin/job/PR-168/1/ just says compatible without deprecation warnings.

@duemir duemir requested a review from timja October 24, 2023 04:38
@duemir duemir self-assigned this Oct 24, 2023
@duemir duemir merged commit 1f0f52a into jenkinsci:master Oct 24, 2023
@duemir duemir deleted the 167-2023.3-compatiblity branch October 25, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Pull requests that update anything related to building the plugin but not the plugin itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addressed compatibility warnings for release 2023.3
2 participants