Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from deprecated imperative File Type definition to the declarative one. #94

Merged
merged 1 commit into from
May 18, 2022
Merged

Switch from deprecated imperative File Type definition to the declarative one. #94

merged 1 commit into from
May 18, 2022

Conversation

duemir
Copy link
Member

@duemir duemir commented May 17, 2022

Internal change. No functional change is expected.
It should unblock dynamic loading, however, there are no Java code inspections for dynamic loading. The code might not be compatible so the plugin might not actually hot reload.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@duemir duemir added the internal Pull requests that update anything related to building the plugin but not the plugin itself label May 17, 2022
@duemir duemir self-assigned this May 17, 2022
@duemir duemir requested review from timja and oleg-nenashev May 17, 2022 08:48
timja
timja approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice I noticed this when trying out gitpod that the plugin didn't hot reload and meant to file an issue

@duemir duemir merged commit 5a94a59 into jenkinsci:master May 18, 2022
@duemir duemir deleted the jelly-file-type branch May 18, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

Assignees

@duemir duemir

Labels
internal Pull requests that update anything related to building the plugin but not the plugin itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duemir @timja