Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the StackOverflowError in Stapler Custom Jelly Taglibrary #99

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix the StackOverflowError in Stapler Custom Jelly Taglibrary #99

merged 1 commit into from
Aug 3, 2022

Conversation

duemir
Copy link
Member

@duemir duemir commented Jul 19, 2022 •
edited
Loading

  • Child tag descriptor lookup is replaced. Instead of delegating to the default namespace the XSD AnyXmlElementDescriptor is re-used.
  • Improve descriptor with check for invokeBody to only allow child tags in the Jelly tag that actually executes its body.
  • Unused "Any" Descriptor is removed

Might fix #88 and/or #66

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@duemir duemir added the bug label Jul 19, 2022
@duemir duemir requested review from oleg-nenashev and timja July 19, 2022 00:17
@duemir duemir self-assigned this Jul 19, 2022
@duemir
Attempt to fix the StackOverflowError
9f00ec9 
* Child tag descriptor lookup is replaced. Instead of delegating to the default namespace the XSD AnyXmlElementDescriptor is re-used.
* Improve descriptor with check for `invokeBody` to only allow child tags in the Jelly tag that actually executes its body.
* Unused "Any" Descriptor is removed
@duemir duemir force-pushed the 88-fix-stackoverflow branch from 2707745 to 9f00ec9 Compare July 19, 2022 00:18
@duemir duemir mentioned this pull request Jul 19, 2022
Closed
@duemir
Copy link
Member Author

duemir commented Jul 19, 2022

Testers are welcome. You can checkout the PR and then do ./gradlew buildPlugin. This should create ./build/distributions/idea-stapler-plugin-2.0.7-SNAPSHOT.zip, which can be installed from disk https://www.jetbrains.com/help/idea/managing-plugins.html#install_plugin_from_disk

@duemir duemir added major-bug and removed bug labels Jul 19, 2022
@duemir duemir linked an issue Jul 19, 2022 that may be closed by this pull request
StackOverflow in Jelly files #66
Closed
@duemir duemir changed the title Attempt to fix the StackOverflowError Fix the StackOverflowError in Stapler Custom Jelly Taglibrary Aug 3, 2022
@duemir duemir merged commit 84ca9ce into jenkinsci:master Aug 3, 2022
@duemir duemir deleted the 88-fix-stackoverflow branch August 3, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

@timja timja Awaiting requested review from timja

Assignees

@duemir duemir

Labels
major-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StackOverflowError when opening Jelly file StackOverflow in Jelly files
1 participant
@duemir