JENKINS-46445 Add support for both client TLS and basic authentication. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesperTerkelsen
force-pushed
the
client-tls-and-auth
branch
from
676f564 to
a53396d
Compare
|
Would you please so kind to add this information to the ReleaseNotes file. |
JesperTerkelsen
force-pushed
the
client-tls-and-auth
branch
from
a53396d to
11be627
Compare
In some setups both client certificate TLS authentication and username password authentication is needed. Here is how you would set it up: - Create a sslContext - add it along with credentials to the new constructor HttpClientBuilder builder = HttpClientBuilder.create(); builder.setSslcontext(sslContext); JenkinsHttpClient client = new JenkinsHttpClient(uri, builder, username, password); JenkinsServer jenkins = new JenkinsServer(client);
JesperTerkelsen
force-pushed
the
client-tls-and-auth
branch
from
11be627 to
2f9c8b4
Compare
|
Sure - i have updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some setups both client certificate TLS authentication and
username password authentication is needed.
Here is how you would set it up.
Create a sslContext, and add it along with credentials this way