[FIXED JENKINS-36593] - Make ItemCategory#MIN_TOSHOW restricted

[oleg-nenashev]

https://issues.jenkins-ci.org/browse/JENKINS-36593

@reviewbybees and esp. @recena

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[recena]

🐝 although this field was introduced in middle of a long process and my recommendation today is to remove it. Really, the service consumer (front-end for example) is who should decide the rendering conditions.

[recena]

@oleg-nenashev How a user is able to change this static field?

[recena]

@oleg-nenashev I'm considering to remove my bee 😄

[oleg-nenashev]

@recena Non-final static fields can be easily changed. E.g. by invoking ItemCategory.MIN_TOSHOW = 5

[recena]

@oleg-nenashev I don't see the problem in this case. This value is only a default value, as a reference to the developer of ItemCategory.

[oleg-nenashev]

Just to summarize the problem, public static fields are evil from the API maintenance perspective. Once you introduce and release the field, there is no real way back. For example, you cannot remove this field without a formal binary compatibility breakage in the Jenkins core.

@Restricted at least allows avoiding explicit usages in other plugins.

[recena]

@oleg-nenashev I understand what you try to achieve but I hope some day, Jenkins provides a policy to deprecate and remove methods, fields, etc.

[oleg-nenashev]

This API deprecation engine originally was in 2.0 scope. I'm not sure if
anybody plans to work on it in short-term. Likely no. But I agree that we
cannot move forward easily without API deprecation
On Jul 12, 2016 8:48 AM, "Manuel Recena" notifications@github.com wrote:

@oleg-nenashev https://github.com/oleg-nenashev I understand what you
try to achieve but I hope some day, Jenkins provides a policy to deprecate
and remove methods, fields, etc.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2449 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AC3IoJwsZUhoYZqXp3ctozFX_BNBC3fhks5qUzjKgaJpZM4JKDoR
.

[oleg-nenashev]

@recena Are you fine with the explanation?

[recena]

@oleg-nenashev Sure.

[oleg-nenashev]

@reviewbybees done
Merging it since the author of the original commit is fine with the change