[JENKINS-36871] JNLP4-connect implementation #2492
Conversation
…ation Todo - [ ] Restore the cookie behaviour (but done right this time) - [ ] Perhaps investigate issuing clients with TLS certificates (but would require a UI for managing them)
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
oleg-nenashev
added
work-in-progress
|
Needs matching release of remoting, but functionally complete |
stephenc
removed
the
work-in-progress
| @@ -56,10 +47,29 @@ | |||
| * @author Kohsuke Kawaguchi | |||
| * @since 1.467 | |||
| */ | |||
| @Extension @Symbol("jnlp") | |||
| @Extension | |||
| @Symbol("jnlp") | |||
|
@jenkinsci/code-reviewers Before going forward, it would be definitely great to know your opinion regarding this binary-incompatible change. @stephenc asked in the Dev List in Twitter and got no response, but it's not a 100% guarantee it's not being used anywhere. But actually it's highly unlikely |
oleg-nenashev
added
the
unresolved-merge-conflict
| keyStore.setKeyEntry("jenkins", privateKey, password, new X509Certificate[]{identityCertificate}); | ||
| } | ||
| } catch (KeyStoreException e) { | ||
| // ignore |
| @@ -180,7 +180,7 @@ THE SOFTWARE. | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.main</groupId> | |||
| <artifactId>remoting</artifactId> | |||
| <version>2.61</version> | |||
| <version>3.0-20160811.164749-2</version> <!-- TODO pick up release of remoting --> | |||
There was a problem hiding this comment.
Ok, I'll refresh this PR
stephenc
removed
the
unresolved-merge-conflict
|
🐝 Test failure is unrelated @jenkinsci/code-reviewers Integration of remoting 3 is being discussed here. By now there are 3 +1s and no -1s. So technically this PR qualifies the merge criteria. |
oleg-nenashev
added
ready-for-merge
|
Merging after the last call for the comments in the developer mailing list. |
|
w00t! |
|
How did I not see that this broke binary and source backwards compatibility... |
|
@jtnord... what ya complaining about... you're getting to rip out all the code that we open sourced and replace with references to the open sourced version |
See JENKINS-36871
This adds the protocol as opt-in, however integrating the protocol required reworking some other classes.
JnlpAgentReceiverwas actually broken (both in binary compatibility and functional compatibility) by the introduction ofJNLP3-connectand we cannot identify any consumers other than a CloudBees closed source plugin, so breaking binary compatibility again is not criticalTodo
Perhaps investigate issuing clients with TLS certificates (but would require a UI for managing them)@jenkinsci/code-reviewers @reviewbybees
See also jenkinsci/remoting#92