-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generates InjectedTest
in a named package.
#587
Conversation
This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general. The package named is derived from groupId and artifactId, but can also be provided through configuration if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, seems reasonable to use a unique name for each plugin to facilitate test result visualizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks helpful. Should not break any tools which run -Dtest=InjectedTest
since that will match a test inside a package.
This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general.
The package name is derived from groupId and artifactId, but can also be provided through configuration if needed.
Testing done
Existing IT
parent-4x
exercises this, though doesn't make any assertion about the actual package name being used. Could add a new one if needed.Submitter checklist