Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generates InjectedTest in a named package. #587

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Generates InjectedTest in a named package. #587

merged 6 commits into from
Mar 13, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Mar 12, 2024 •
edited

This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general.

The package name is derived from groupId and artifactId, but can also be provided through configuration if needed.

Testing done

Existing IT parent-4x exercises this, though doesn't make any assertion about the actual package name being used. Could add a new one if needed.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@Vlatombe
Generates InjectedTest in a named package.
e9901b3 
This makes the test friendlier to JUnit results collection when working with PCT or in multi-module projects in general.

The package named is derived from groupId and artifactId, but can also be provided through configuration if needed.
@Vlatombe Vlatombe requested review from jglick and basil March 12, 2024 14:17
basil
basil approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, seems reasonable to use a unique name for each plugin to facilitate test result visualizations.

jglick
jglick approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful. Should not break any tools which run -Dtest=InjectedTest since that will match a test inside a package.

src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java Outdated Show resolved Hide resolved
jglick

This comment was marked as resolved.

Sign in to view

@MarkEWaite MarkEWaite merged commit 9ae61e8 into jenkinsci:master Mar 13, 2024
5 checks passed
@Vlatombe Vlatombe deleted the package-injectedTest branch March 13, 2024 07:44
@basil basil mentioned this pull request Apr 12, 2024
Merged
@basil basil mentioned this pull request May 8, 2024
Merged
basil added a commit to jenkinsci/plugin-compat-tester that referenced this pull request Jun 11, 2024
@basil
Adapt to jenkinsci/maven-hpi-plugin#587 by @Vlatombe
17bf845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@jglick jglick jglick approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vlatombe @basil @jglick @MarkEWaite