Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permitting ${hpi.compatibleSinceVersion} to be used to configure mojos rather than a <plugin> section #90

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 14, 2019

To simplify plugin POMs, especially after jenkinsci/plugin-pom#134 (no need for a plugin-pom patch).

@jglick
Copy link
Member Author

jglick commented Jan 14, 2019

Actually this is not even needed as jenkinsci/performance-signature-dynatrace-plugin#6 shows, but it would still save some space in plugin POMs.

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I didn't try it locally.

@jglick
Copy link
Member Author

jglick commented Jan 15, 2019

Nor I, yet. Guess I can try to create a downstream PR for it.

Test failure was a SocketTimeoutException, looks like a flake.

@jglick
Copy link
Member Author

jglick commented Jan 15, 2019

This worked in workflow-support-plugin:

diff --git a/pom.xml b/pom.xml
index b27b796..56e2dbd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,6 +68,8 @@
         <java.level>8</java.level>
         <no-test-jar>false</no-test-jar>
         <useBeta>true</useBeta>
+        <hpi-plugin.version>3.2-SNAPSHOT</hpi-plugin.version>
+        <hpi.compatibleSinceVersion>3.0</hpi.compatibleSinceVersion>
         <git-plugin.version>3.7.0</git-plugin.version>
         <workflow-scm-step-plugin.version>2.6</workflow-scm-step-plugin.version>
         <workflow-step-api-plugin.version>2.13</workflow-step-api-plugin.version>
@@ -217,16 +219,4 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.jenkins-ci.tools</groupId>
-                <artifactId>maven-hpi-plugin</artifactId>
-                <extensions>true</extensions>
-                <configuration>
-                    <compatibleSinceVersion>3.0</compatibleSinceVersion>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
 </project>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants