Let's try to keep our building tools up-to-date Why ? Because ... #13
Conversation
|
WDYT @jenkinsci/code-reviewers cc @reviewbybees |
There was a problem hiding this comment.
I like the idea of updating to latest releases of the maven plugins, but would prefer that it be a series of individual commits, each with a build comment stating the plugin name, the previous version, and the new version.
I realize that is more work for you, but that technique (in the past) has made it simpler for me to revert a single commit when I realize that a particular plugin upgrade broke the build. It also makes it easier to search for that breaking change to a plugin because I can use git bisect to assist with the search.
| @@ -13,7 +13,7 @@ | |||
| <inceptionYear>2004</inceptionYear> | |||
|
|
|||
| <prerequisites> | |||
| <maven>2.2.1</maven> | |||
| <maven>3.2.2</maven> | |||
There was a problem hiding this comment.
I assume you chose 3.2 instead of 3.3 because you wanted to retain compatibility with Java 6 for those plugins which may still be running with Java 6.
Was there a reason you didn't choose 3.2.5 instead of 3.2.2? The 3.2.5 release was over two years ago, and it supports Java 6.
There was a problem hiding this comment.
We should probably remove the whole <prerequisites> section as that is only relevant when building maven plugins https://issues.apache.org/jira/browse/MNG-6092
There was a problem hiding this comment.
@stephenc yes +1000
@MarkEWaite the choice of 3.2.2 is coming from the report done by mvn versions:display-plugin-updates which is verifying the requirement of each plugin declared in the POM. But yes we may target the latest 3.2.x
|
yes, it's not a problem @MarkEWaite to do that. I'll do it later. |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@aheritier any plans to address the comments from @MarkEWaite ? |
|
@oleg-nenashev I completely forgot it. Sorry @MarkEWaite |
|
There will be collision with #14 |
No description provided.