Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing forced JUnit dep. #7

Merged
merged 2 commits into from
Feb 7, 2013
Merged

Removing forced JUnit dep. #7

merged 2 commits into from
Feb 7, 2013

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 24, 2012

As http://stackoverflow.com/questions/7898446/how-to-exclude-a-dependency-from-parents-project-in-maven notes, it is impossible to remove a dependency specified in a parent POM. Generally a POM project just should not declare dependencies at all; it can use dependencyManagement where useful.

Affects jenkins-test-harness, which is trying to depend on JUnit 4.10 but is also stuck with this obsolete JUnit 3.8 from a parent.

@buildhive
Copy link

Jenkins » pom #2 SUCCESS
This pull request looks good
(what's this?)

@jglick
Copy link
Member Author

jglick commented Jul 24, 2012

Problem in e.g. jenkins-test-harness is that junit.* classes are in compile CP in 4.10 but test CP in 3.8. But due to the bad parent POM we cannot simply override junit:junit because we want junit:junit-dep in compile CP so as to avoid dumping random versions of Hamcrest classes in the CP. JUnit 4.11 will not suffer from this confusion: https://github.com/KentBeck/junit/pull/421

@buildhive
Copy link

Jenkins » pom #12 SUCCESS
This pull request looks good
(what's this?)

jglick added a commit that referenced this pull request Feb 7, 2013
Removing forced JUnit dep.
@jglick jglick merged commit 092b519 into jenkinsci:master Feb 7, 2013
@jglick jglick deleted the no-junit-dep branch February 7, 2013 23:11
@jglick
Copy link
Member Author

jglick commented Feb 27, 2013

@kohsuke care to release this? Probably a prerequisite for moving to JUnit 4.11 in Jenkins trunk, which is valuable since it introduces predictable test case ordering within a suite even on Java 7 (which returns Class.declaredMethods in a random order).

@kohsuke
Copy link
Member

kohsuke commented Feb 27, 2013

1.30 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants