Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the id parameter of analysisModel tool to analysisModelId #1135

Merged
merged 3 commits into from
Dec 5, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Dec 3, 2021

Otherwise we cannot replace the tool ID with a custom ID.

@uhafner uhafner added the bug Bugs or performance problems label Dec 3, 2021
…delId`.

Otherwise, one cannot replace the tool ID with a custom ID.
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #1135 (44ac5b6) into master (d56db52) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1135      +/-   ##
============================================
+ Coverage     79.95%   80.04%   +0.08%     
- Complexity     1485     1489       +4     
============================================
  Files           244      244              
  Lines          5414     5418       +4     
  Branches        426      426              
============================================
+ Hits           4329     4337       +8     
+ Misses          929      926       -3     
+ Partials        156      155       -1     
Impacted Files Coverage Δ
...a/io/jenkins/plugins/analysis/core/model/Tool.java 72.50% <100.00%> (+2.22%) ⬆️
...ns/plugins/analysis/warnings/RegisteredParser.java 100.00% <100.00%> (+26.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56db52...44ac5b6. Read the comment docs.

@uhafner uhafner merged commit 4d97b28 into master Dec 5, 2021
@uhafner uhafner deleted the analysisModelId branch December 5, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant