Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use responsive columns for all tables #1290

Merged
merged 8 commits into from
Jun 18, 2022
Merged

Use responsive columns for all tables #1290

merged 8 commits into from
Jun 18, 2022

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Jun 11, 2022

Using the width option does not work as expected so it makes more sense to let DataTables internal code decide which width should be used for each column. If the columns do not fit on the page then columns will be hidden according the specified responsivePriority.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Jun 11, 2022
- add `responsivePriority` for a column
- remove broken `width` properties.
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1290 (f591130) into master (24dad83) will increase coverage by 0.26%.
The diff coverage is 96.61%.

@@             Coverage Diff              @@
##             master    #1290      +/-   ##
============================================
+ Coverage     79.40%   79.66%   +0.26%     
- Complexity     1440     1442       +2     
============================================
  Files           247      248       +1     
  Lines          5437     5522      +85     
  Branches        425      425              
============================================
+ Hits           4317     4399      +82     
- Misses          971      974       +3     
  Partials        149      149              
Impacted Files Coverage Δ
...plugins/analysis/core/model/DetailsTableModel.java 94.36% <90.32%> (-3.56%) ⬇️
...lugins/analysis/warnings/DuplicateCodeScanner.java 84.76% <94.44%> (+1.96%) ⬆️
...nkins/plugins/analysis/core/model/BlamesModel.java 93.33% <100.00%> (+3.67%) ⬆️
...ns/plugins/analysis/core/model/ForensicsModel.java 94.18% <100.00%> (+1.99%) ⬆️
...nkins/plugins/analysis/core/model/IssuesModel.java 97.87% <100.00%> (+0.43%) ⬆️
...o/jenkins/plugins/analysis/warnings/BluePearl.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dad83...f591130. Read the comment docs.

@uhafner uhafner merged commit ea3fac9 into master Jun 18, 2022
@uhafner uhafner deleted the responsive-columns branch June 18, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant