Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylelint as checkstyle reporter #1307

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jul 10, 2022

The change proposed adds stylint as alias for the checkstyle reporter. Follow up to jenkinsci/analysis-model#812

We may need an update of analysis-mode plus its api here, I'm not too sure about it.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@uhafner uhafner changed the title feat: Add stylelint as checkstyle reporter Add stylelint as checkstyle reporter Jul 10, 2022
@uhafner uhafner changed the title Add stylelint as checkstyle reporter Add Stylelint as checkstyle reporter Jul 10, 2022
@uhafner uhafner added the enhancement Enhancement of existing functionality label Jul 10, 2022
@uhafner
Copy link
Member

uhafner commented Jul 10, 2022

You need to merge in #1310

@NotMyFault
Copy link
Member Author

NotMyFault commented Jul 10, 2022

You need to merge in #1310

Oic, thanks a bunch of the quick release. I'll merge it into this PR once it's merged into master 👍🏻

@NotMyFault NotMyFault requested a review from uhafner July 11, 2022 11:48
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1307 (d6c4a2c) into master (8514635) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master    #1307   +/-   ##
=========================================
  Coverage     79.66%   79.66%           
- Complexity     1442     1443    +1     
=========================================
  Files           248      249    +1     
  Lines          5522     5528    +6     
  Branches        425      425           
=========================================
+ Hits           4399     4404    +5     
- Misses          974      975    +1     
  Partials        149      149           
Impacted Files Coverage Δ
...o/jenkins/plugins/analysis/warnings/StyleLint.java 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8514635...d6c4a2c. Read the comment docs.

@NotMyFault
Copy link
Member Author

You need to merge in #1310

Oic, thanks a bunch of the quick release. I'll merge it into this PR once it's merged into master 👍🏻

There we go, checks are all green.

@uhafner uhafner merged commit 0775fb9 into jenkinsci:master Jul 11, 2022
@NotMyFault NotMyFault deleted the feat/master/stylelint branch July 11, 2022 17:36
@NotMyFault
Copy link
Member Author

Hey,

would you mind cutting a release please? I'm looking forward to use the recent addition on ci.j 👀

Thanks in advance!

@uhafner
Copy link
Member

uhafner commented Jul 12, 2022

https://github.com/jenkinsci/warnings-ng-plugin/releases/tag/v9.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants