Include parser for Polyspace static analysis tool #1412

evahabeeballah · 2022-11-27T13:04:39Z

This pull request is to include a parser for .csv result files generated from Polyspace tool.
This request is linked analysis-model pull request: https://github.com/jenkinsci/analysis-model/pull/863
Link for polyspace static analysis tool: https://de.mathworks.com/products/polyspace.html

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

uhafner

Requires a release (or incremental version) of https://github.com/jenkinsci/analysis-model-api-plugin before we can merge this change. You can reference that version in the pom.xml if it has been published.

Regarding your questions:

Is it possible to change the names of the severity categories to something else other than Low, Normal, High? For example: Error, Not-Run, Warning, Incomplete.

No this is not possible, all parsers share the same model and the same severities.

Regarding the License for the addition of icons in Warnings-NG, what is expected to be provided if the icon was created based on the logo of the tool (Cropped and resized) ?

You need to use the logo license as starting point. What is the current license? If this license allows modifications that we simply can stick to it. Note: it would be helpful to use an SVG if possible.

evahabeeballah · 2022-12-13T08:14:03Z

Since the changes done on analysis-model have been released, do i also need to do any changes on analysis-model-api for the version or is it updated already?
Is it correct that the most recent version of analysis-model-api that also includes our changes is 10.22.0 (what should be reference in pom.xml of warnings-ng-plugin)?

uhafner · 2022-12-13T22:54:14Z

I updated the pom.xml so you need to rebase and retry.

codecov · 2022-12-19T11:25:43Z

Codecov Report

Merging #1412 (ac7a808) into master (5ca5a1b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1412      +/-   ##
============================================
+ Coverage     79.80%   79.83%   +0.02%     
- Complexity     1471     1473       +2     
============================================
  Files           252      254       +2     
  Lines          5636     5644       +8     
  Branches        425      425              
============================================
+ Hits           4498     4506       +8     
  Misses          986      986              
  Partials        152      152

Impacted Files	Coverage Δ
...o/jenkins/plugins/analysis/warnings/Polyspace.java	`100.00% <100.00%> (ø)`
...nkins/plugins/analysis/warnings/SimulinkCheck.java	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

evahabeeballah · 2022-12-19T13:27:44Z

Hi,
Regarding the 'Enforce PR labels / enforce-label (pull_request)' check that is failed, can you please let me know what that means, or what can I do to pass the check?

uhafner · 2022-12-19T16:10:25Z

Hi,
Regarding the 'Enforce PR labels / enforce-label (pull_request)' check that is failed, can you please let me know what that means, or what can I do to pass the check?

This is a check for me so that I do not merge without a label.

uhafner · 2022-12-19T20:52:48Z

plugin/src/main/java/io/jenkins/plugins/analysis/warnings/PolyspaceParse.java

+    }
+
+    /** Descriptor for this static analysis tool. */
+    @Symbol("PolyspaceParse")


Seems that I missed that detail in my analysis-model PR.

Wouldn't that be a more appropriate symbol?

Suggested change

@Symbol("PolyspaceParse")

@Symbol("polyspaceParser")

Where does the Parse part came from? Is the tool called Polyspace Parse? Or is this suffix solely from your parser?

Either way: symbols need to use CamelCase, IDs need to use url-notation (all lower case). I can fix that right away in the analysis model as well.

What do you think?

The idea was to differentiate between polyspace commands and the parser command, just in case there is a command from polyspace tool defined in the same way as 'polyspace'.

I see. Then let us use polyspaceParser if that is fine for you as well, since we already have several other tools that do it this way (PMD, AndroidLint).

The appropriate ID would then be polyspace-parser.

Yes polyspace-parser would be fine then. I will change that now.

In analysis-model as well?

Yes also in analysis-model. But you can change that ? Since the pull request is already approved.

Yes, this library is under my control and only used by tools that I control. So no worries...

I will also do the same for the Simulink check Parser in the other Pull request

uhafner · 2022-12-19T20:56:31Z

plugin/src/main/webapp/icons/LICENSE.txt

+Polyspace icon:
+
+The Polyspace icon is based on tool logo from https://w...mathworks.com/products/polyspace.html
+Licensed by The MathWorks, Inc


What is the actual license? Are we allowed to add it to our MIT based project?

After checking the licence file, we are not sure if we can use it this way. I will remove the icon file and push the changes again, will that be okay ?

Yes, this would be more safe. Image licensing is always problematic...

evahabeeballah · 2023-01-23T09:35:24Z

Hello, I am not sure what is the problem with this pull request. Can you please let me know if there is anything to be done from my side. Thanks !

…gsNG

uhafner · 2023-01-23T21:54:55Z

plugin/pom.xml

@@ -25,7 +25,7 @@
    <changelist>-SNAPSHOT</changelist>
    <module.name>${project.groupId}.warnings.ng</module.name>

-    <analysis-model-api.version>10.21.0</analysis-model-api.version>
+    <analysis-model-api.version>10.22.0</analysis-model-api.version>


I think you simply forgot to update the model version.

Include parser for Polyspace static analysis tool

9de1b47

github-actions bot assigned uhafner Nov 27, 2022

uhafner marked this pull request as draft November 30, 2022 10:33

uhafner requested changes Nov 30, 2022

View reviewed changes

evahabeeballah and others added 3 commits December 15, 2022 17:24

Merge branch 'jenkinsci:master' into polyspace-parser-warningsNG

220a207

Polyspace Parser

17ba6d0

Merge branch 'jenkinsci:master' into polyspace-parser-warningsNG

cd58f1d

uhafner added the enhancement Enhancement of existing functionality label Dec 19, 2022

uhafner reviewed Dec 19, 2022

View reviewed changes

evahabeeballah and others added 2 commits December 20, 2022 16:59

Merge branch 'jenkinsci:master' into polyspace-parser-warningsNG

fc20306

Parser ID and Symbol Change & Icon Removed

ca7defe

evahabeeballah mentioned this pull request Jan 11, 2023

Parser ID update to 'polyspace-parser' jenkinsci/analysis-model#872

Merged

6 tasks

Merge branch 'jenkinsci:master' into polyspace-parser-warningsNG

ed6f431

evahabeeballah marked this pull request as ready for review January 23, 2023 08:40

evahabeeballah and others added 7 commits January 23, 2023 11:18

Include Parser for Simulink Check Code Generator

c15e989

Merge branch 'master' into polyspace-parser-warningsNG

7774874

Bum version of analysis-model to 10.22.0.

99eb571

Merge branch 'simulink-check-warningsNG' into polyspace-parser-warnin…

7aa7391

…gsNG

Use the same styling for all tools.

6bdcd34

Restore missing sierial version.

846f789

Use same order for ID.

63bbf18

uhafner approved these changes Jan 23, 2023

View reviewed changes

Remove failing Code QL scanner.

ac7a808

uhafner approved these changes Jan 24, 2023

View reviewed changes

uhafner merged commit 9cd8fc3 into jenkinsci:master Jan 24, 2023

evahabeeballah mentioned this pull request Feb 1, 2023

Fix parsing of line and column numbers in Polyspace parser jenkinsci/analysis-model#883

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include parser for Polyspace static analysis tool #1412

Include parser for Polyspace static analysis tool #1412

evahabeeballah commented Nov 27, 2022 •

edited

Loading

uhafner left a comment

evahabeeballah commented Dec 13, 2022

uhafner commented Dec 13, 2022

codecov bot commented Dec 19, 2022 •

edited

Loading

evahabeeballah commented Dec 19, 2022

uhafner commented Dec 19, 2022

uhafner Dec 19, 2022 •

edited

Loading

evahabeeballah Dec 20, 2022

uhafner Dec 20, 2022

uhafner Dec 20, 2022

evahabeeballah Dec 20, 2022

uhafner Dec 20, 2022

evahabeeballah Dec 20, 2022

uhafner Dec 20, 2022

evahabeeballah Dec 20, 2022

uhafner Dec 19, 2022

evahabeeballah Dec 20, 2022

uhafner Dec 20, 2022

evahabeeballah commented Jan 23, 2023

uhafner Jan 23, 2023

Include parser for Polyspace static analysis tool #1412

Include parser for Polyspace static analysis tool #1412

Conversation

evahabeeballah commented Nov 27, 2022 • edited Loading

uhafner left a comment

Choose a reason for hiding this comment

evahabeeballah commented Dec 13, 2022

uhafner commented Dec 13, 2022

codecov bot commented Dec 19, 2022 • edited Loading

Codecov Report

evahabeeballah commented Dec 19, 2022

uhafner commented Dec 19, 2022

uhafner Dec 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evahabeeballah commented Jan 23, 2023

Choose a reason for hiding this comment

evahabeeballah commented Nov 27, 2022 •

edited

Loading

codecov bot commented Dec 19, 2022 •

edited

Loading

uhafner Dec 19, 2022 •

edited

Loading