Add support for protolint #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhafner
requested changes
Oct 24, 2019
| */ | ||
| public class ProtoLint extends ReportScanningTool { | ||
|
|
||
| private static final long serialVersionUID = -5718503998068521571L; |
There was a problem hiding this comment.
Wrong indention, strange that this is not reported by Codacy...
|
|
||
| @Override | ||
| public boolean canScanConsoleLog() { | ||
| return false; |
There was a problem hiding this comment.
Why is that? Should be used only for JSON or XML reports. I think you are parsing single lines... You can remove the method.
| } | ||
|
|
||
| @Override | ||
| public StaticAnalysisLabelProvider getLabelProvider() { |
There was a problem hiding this comment.
Delete this method, this is the default implementation
|
I have no idea why this failed. |
|
Hmm, I also don't know what is wrong in GitHub Actions windows build, the command is |
uhafner
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pareser for protolint