Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin from 4.31 to 4.32 #78

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 27, 2021

Bumps plugin from 4.31 to 4.32.

Release notes

Sourced from plugin's releases.

4.32

馃殌 New features and improvements

馃悰 Bug fixes

馃摝 Dependency updates

馃摑 Documentation updates

馃懟 Maintenance

Commits
  • f090513 [maven-release-plugin] prepare release plugin-4.32
  • 07811b5 Work around issues on 2.222.x, 2.235.x, and 2.289.x (#477)
  • 04593ab Bump jenkins-test-harness from 1666.vd1360abbfe9e to 1674.v3b8b1441e939 (#476)
  • 1d4873a Bump maven-hpi-plugin from 3.21 to 3.22
  • e541b0e Bump mockito.version from 4.1.0 to 4.2.0
  • 0a52aed Bump access-modifier from 1.25 to 1.27 (#473)
  • f68c0ab Merge pull request #472 from jenkinsci/Vlatombe-patch-1
  • 6920ebd Update README.md
  • 71620ed Merge pull request #471 from Vlatombe/enforcer-rules
  • 1673c19 Update versions in README
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @jglick.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 27, 2021
@jglick
Copy link
Member

jglick commented Jan 4, 2022

@dependabot merge

@jglick
Copy link
Member

jglick commented Jan 4, 2022

@dependabot rebase

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.31 to 4.32.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.31...plugin-4.32)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci.plugins-plugin-4.32 branch from 3871c7e to 463413e Compare January 4, 2022 16:36
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@jglick
Copy link
Member

jglick commented Jan 4, 2022

Yet another thing apparently waiting for jenkinsci/mailer-plugin#138 because of some unclear behavioral change from jenkinsci/plugin-pom#456 @basil? I think 4.32 release notes need to emphasize that this is expected to be an incompatible update for many plugins.

@basil
Copy link
Member

basil commented Jan 4, 2022

Yeah this new Enforcer version is really annoying. I'll update the release notes once I have a recommendation, which will be to update to the latest BOM prior to upgrading the plugin parent POM. But I can't write that until the Mailer fix is released and makes it into the plugin BOM.

@jglick
Copy link
Member

jglick commented Jan 4, 2022

Do you understand what exactly changed in Enforcer? Something about the algorithm it uses to locate dependency trails I suppose.

@basil
Copy link
Member

basil commented Jan 4, 2022

Do you understand what exactly changed in Enforcer?

Everything I've seen so far has been with provided dependencies, so I'm guessing it was skipping over those before but it's enforcing them now.

@jglick
Copy link
Member

jglick commented Jan 4, 2022

until the Mailer fix is released

https://github.com/jenkinsci/mailer-plugin/releases/tag/391.ve4a_38c1b_cf4b_

@basil
Copy link
Member

basil commented Jan 4, 2022

Sigh, now we need jenkinsci/plugin-util-api-plugin#150. What a giant pain.

@basil
Copy link
Member

basil commented Jan 5, 2022

I updated the release notes with instructions on how to cross this flag day.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 7, 2022

Looks like org.jenkins-ci.plugins:plugin is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 7, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci.plugins-plugin-4.32 branch January 7, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
2 participants