MSYS2+MINGW64 platform with libbacktrace #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LS_WITH_LIBBACKTRACE=On option.
|
Hi thanks so much for doing this! I was never able to get libbacktrace working on mingw. I think I made a mistake with program_name that will block this PR, currently it returns a std::string on windows and const char* elsewhere. It would be good to have it just return const char* on windows too. If you’re able to fix that as part of this PR I’d appreciate it, otherwise I can fix it on dev. |
jeremy-rifkin
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated cmake conditions, to allow libbacktrace usage under mingw64. And fixed one compilation issue.
Tested with package https://packages.msys2.org/package/mingw-w64-x86_64-libbacktrace
with this setup: