Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add b2_index() and tests for tree balance #5

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Billyzhang1229
Copy link
Contributor

Add doc for sackin_index()

Copy link
Owner

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The git history has got muddled up though, and you need to rebase. This guide that I wrote for another project should help.

If you're getting stuck ping me or Ben on Slack and we'll walk you through it (everyone get's stuck on rebasing the first few times!)

phylokit/balance.py Show resolved Hide resolved
@jeromekelleher
Copy link
Owner

Also, please squash down to one commit while you're rebasing (in general, one commit per PR is a good rule of thumb, unless there's a set of discrete things that would be good to keep history for in there)

Add doc for sackin_index()
@Billyzhang1229
Copy link
Contributor Author

Rebased✅

@jeromekelleher jeromekelleher merged commit abf1605 into jeromekelleher:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants