New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Comment Enhancer breaks Github's name completion #81

Closed
thomaslevesque opened this Issue Oct 25, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@thomaslevesque

When you type "@", Github displays a list of suggestions to mention other people. When GCE is enabled, I can no longer pick a choice from this list with the keyboard, I have to use the mouse.

@jerone

This comment has been minimized.

Show comment
Hide comment
@jerone

jerone Oct 26, 2015

Owner

Thanks for reporting. I've noticed it too, never thought to link it to Github Comment Enhancer.
Confirmed and same goes for emoji.

Owner

jerone commented Oct 26, 2015

Thanks for reporting. I've noticed it too, never thought to link it to Github Comment Enhancer.
Confirmed and same goes for emoji.

@jerone

This comment has been minimized.

Show comment
Hide comment
@jerone

jerone Nov 19, 2015

Owner

Wow, that was a hard one to fix. Hopefully tracked the cause down.

@thomaslevesque Any change you could test if the fix solves the problem for you too: https://github.com/jerone/UserScripts/blob/Github_Comment_Enhancer/Github_Comment_Enhancer/Github_Comment_Enhancer.user.js (click Raw to install dev version).

Owner

jerone commented Nov 19, 2015

Wow, that was a hard one to fix. Hopefully tracked the cause down.

@thomaslevesque Any change you could test if the fix solves the problem for you too: https://github.com/jerone/UserScripts/blob/Github_Comment_Enhancer/Github_Comment_Enhancer/Github_Comment_Enhancer.user.js (click Raw to install dev version).

@thomaslevesque

This comment has been minimized.

Show comment
Hide comment
@thomaslevesque

thomaslevesque Nov 19, 2015

@jerone, it works :)

Well done and thanks ! This bug was really annoying ;)

@jerone, it works :)

Well done and thanks ! This bug was really annoying ;)

@jerone

This comment has been minimized.

Show comment
Hide comment
@jerone

jerone Nov 20, 2015

Owner

I'm working on another fix for using the keyboard on the toolbar dropdown buttons too. After that I'll release a new version of Github Comment Enhancer, so you can switch back to the live version.

Owner

jerone commented Nov 20, 2015

I'm working on another fix for using the keyboard on the toolbar dropdown buttons too. After that I'll release a new version of Github Comment Enhancer, so you can switch back to the live version.

@thomaslevesque

This comment has been minimized.

Show comment
Hide comment

OK, thanks!

@jerone jerone closed this in 58f74cd Nov 21, 2015

@jerone

This comment has been minimized.

Show comment
Hide comment
@jerone

jerone Nov 21, 2015

Owner

Fixed and 🚢ed

Owner

jerone commented Nov 21, 2015

Fixed and 🚢ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment