Port to generalized log parser #5
Conversation
There was a problem hiding this comment.
Horray for cleaning this up! This should fix: jerrymarino/SwiftVimTestHost#1
| } | ||
|
|
||
| /// Check if the first non " " argument is clang | ||
| func isCC(lexed: [String]) -> Bool { |
There was a problem hiding this comment.
None of these naive checks will work with custom compilers ( for clang and swiftc ), that is an edge case that this program doesn't need to handle ATM. It should be at least called out.
| return swiftSources.filter { $0.hasSuffix(swiftFile) }.first ?? swiftSources.first | ||
| } | ||
|
|
||
| func workingDirectoryInSwiftInvocation(lexed: [String]) -> String? { |
There was a problem hiding this comment.
We could probably just use the cd action, as clang. The previous program did not, so continue to parse this.
| } | ||
| } | ||
|
|
||
| if objectFile == "" { |
There was a problem hiding this comment.
Add a comment: this assumes -primary-file is being used and the first file is reasonable.
|
|
||
| class LogParsingTests: XCTestCase { | ||
|
|
||
| func atestFrontendInvocation() { |
| } | ||
| } | ||
|
|
||
| func isspace(_ c: String) -> Bool { |
There was a problem hiding this comment.
This can probably be inlined.
|
|
||
| echo "Installing to /usr/local/bin" | ||
| ditto build/Release/XCCompilationDB /usr/local/bin | ||
| ditto .build/release/XcodeCompilationDatabase /usr/local/bin/XCCompilationDB |
There was a problem hiding this comment.
This should probably just be in the makefile as the default target.
jerrymarino
force-pushed
the
jmarino_log_parsing
branch
2 times, most recently
from
9cd7f77 to
1f5eef7
Compare
This patch ports the program to a simple log parser. It is orders of magnitude to maintain, reason about, debug, and use. Previously, it was relying on internal data structures of Xcode, which integrated nice into Xcode's build system. While novel, there are several pitfalls: - Keeping up with Apple's changes - The new llbuild based build system doesn't use the same data structures - It only works with some of the build - It was too hard to debug Parsing logs has *several pitfalls too* but is better than other evils like: - using Xcode or Swift internals ( prev impl ) - swapping out compilers in the build system and writing argv to a file ( very bad for many reasons! ) This patch implements a very generalized log parser that accepts input from *virtually any log containing swift frontend invocations*. In the future, it may get away from using frontend invocations, and that would be a follow up. Testing: - Unit tests - Integration tests
jerrymarino
force-pushed
the
jmarino_log_parsing
branch
from
1f5eef7 to
20121a2
Compare
jerrymarino
changed the title
This patch ports the program to a simple log parser. It is orders of
magnitude easier to maintain, reason about, debug, and use.
Previously, it was relying on internal data structures of Xcode, which
integrated nice into Xcode's build system. While novel, there are several pitfalls:
Parsing logs has several pitfalls too but is better than other evils
like:
argv to a file ( very bad for many reasons! )
This patch implements a very generalized log parser that accepts input
from virtually any log containing swift frontend actions. In the future,
we'll get away from this, and that will be a follow up.
Testing: