Skip to content

Fix PropertyDefinition parsing in ObjectInitializer #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fix PropertyDefinition parsing in ObjectInitializer #3832

merged 1 commit into from
Jun 3, 2020
+108 −2

Conversation

rerobika
Copy link
Member

@rerobika rerobika commented Jun 2, 2020

This patch fixes #3822.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika rerobika added the bug Undesired behaviour label Jun 2, 2020
@rerobika rerobika linked an issue Jun 2, 2020 that may be closed by this pull request
Assertion 'scope_stack_p > context_p->scope_stack_p' in scanner_literal_is_created #3823
Closed
@rerobika rerobika linked an issue Jun 2, 2020 that may be closed by this pull request
Assertion 'context.status_flags & PARSER_SCANNING_SUCCESSFUL' in parser_parse_source #3824
Closed
@rerobika rerobika linked an issue Jun 2, 2020 that may be closed by this pull request
Assertion 'block_found' in parser_parse_try_statement_end #3825
Closed
zherczeg
zherczeg reviewed Jun 2, 2020
View reviewed changes
@rerobika rerobika linked an issue Jun 3, 2020 that may be closed by this pull request
Assertion 'context_p->next_scanner_info_p->type == SCANNER_TYPE_FUNCTION' in parser_parse_function_arguments #3835
Closed
@rerobika
Fix PropertyDefinition parsing in ObjectInitializer
3bf4b7c 
This patch fixes jerryscript-project#3822 and fixes jerryscript-project#3823 and fixes jerryscript-project#3824 and fixes jerryscript-project#3825.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
zherczeg
zherczeg approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 4660bab into jerryscript-project:master Jun 3, 2020
@rerobika rerobika deleted the fix_issue_3822 branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zherczeg zherczeg zherczeg approved these changes

@dbatyai dbatyai dbatyai approved these changes

Assignees
No one assigned
Labels
bug Undesired behaviour
Projects
None yet
Milestone
No milestone
3 participants
@rerobika @zherczeg @dbatyai