cmake: avoid Apple ranlib flags when not using AppleClang #5258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, `-no_warning_for_no_symbols -c` options are specific to the Apple `ranlib` tool. When using other toolchains (e.g. Homebrew clang), these flags cause errors since `llvm-ranlib` does not recognize them. The patch ensures these flags are only passed when using AppleClang. JerryScript-DCO-1.0-Signed-off-by: Renata Hodovan reni@inf.u-szeged.hu
renatahodovan
force-pushed
the
appleclang
branch
from
61570a2 to
91f8ffa
Compare
zherczeg
approved these changes
Oct 8, 2025
akosthekiss
merged commit b706935
into
jerryscript-project:master
28 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS,
-no_warning_for_no_symbols -coptions are specific to the Appleranlibtool. When using other toolchains (e.g. Homebrew clang), these flags cause errors sincellvm-ranlibdoes not recognize them.The patch ensures these flags are only passed when using AppleClang.