Update dependencies and tests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to the latest versions of the dependencies and also updated the tests to use a css property that generates some prefixes since flexbox no longer needs prefixes for the default browserslist config.
brwnrclse
commented
May 25, 2019
| @@ -1,3 +1,4 @@ | |||
| --reporter spec | |||
| --compilers coffee:coffee-script/register | |||
There was a problem hiding this comment.
| @@ -1,2 +1,2 @@ | |||
| p | |||
| display: flex | |||
There was a problem hiding this comment.
Since browserslist uses > 0.5%, last 2 versions, Firefox ESR, not dead as its default I swapped flexbox out for a css rule that gets prefixes. https://github.com/browserslist/browserslist
|
Nice 🎉 Since this have been merged 21 days ago, do you have any plan to release it on npm @jescalan? |
drazik
added a commit
to cozy/cozy-ui
that referenced
this pull request
Jul 26, 2019
In postcss config, we gave the browsers list to autoprefixer plugin directly. But the `browsers` property is deprecated and will be removed in next major version (see https://github.com/postcss/autoprefixer/releases/tag/9.6.0). We also use autoprefixer through autoprefixer-stylus, but it uses a very old version of autoprefixer (7.1.0) that doesn't understand the `dead` query that our browserslist config uses. A PR fixing this have been merged and will hopefuly be released soon, see jescalan/autoprefixer-stylus#180. That's why I left the custom browserslist config for autoprefixer-stylus in `build:css`, `build:css:utils` and `build:css:kss` scripts for now. But we should upgrade this module and stop using a custom browserslist config for it as soon as possible.
drazik
added a commit
to cozy/cozy-ui
that referenced
this pull request
Jul 26, 2019
In postcss config, we gave the browsers list to autoprefixer plugin directly. But the `browsers` property is deprecated and will be removed in next major version (see https://github.com/postcss/autoprefixer/releases/tag/9.6.0). We also use autoprefixer through autoprefixer-stylus, but it uses a very old version of autoprefixer (7.1.0) that doesn't understand the `dead` query that our browserslist config uses. A PR fixing this have been merged and will hopefuly be released soon, see jescalan/autoprefixer-stylus#180. That's why I left the custom browserslist config for autoprefixer-stylus in `build:css`, `build:css:utils` and `build:css:kss` scripts for now. But we should upgrade this module and stop using a custom browserslist config for it as soon as possible.
|
Hey @drazik - just released here https://github.com/jescalan/autoprefixer-stylus/releases/tag/v1.0.0 |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the latest versions of the dependencies and also updated the tests to
use a css property that generates some prefixes since flexbox no longer needs
prefixes when using the default browserslist config.
Fix for: #179