Re-render text area of editable views when view size changes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the size of an editable view changes, try to scroll it to (0,0), and then make the cursor visible again if needed. This is maybe not the ideal behavior when the rendered content exceeds the size of the view, but it's good enough, and simple. This is relevant in two cases: when the terminal size changes while an editable view is showing, and the first time we resize a view to its actual size in layout() after showing it for the first time. For the second case we currently have code that resizes the panel to its real size before showing the view, so that the text area is scrolled correctly; we can get rid of that code now (which is the main purpose of this commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for jesseduffield/lazygit#3694, and reviewed as part of it.